add missing query flags to client status query cli #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
seantking and
damiannolan
as code owners
crodriguezvega
changed the title
damiannolan
approved these changes
Sep 9, 2022
chatton
approved these changes
Sep 9, 2022
| @@ -79,7 +79,6 @@ func NewCreateClientCmd() *cobra.Command { | |||
| } | |||
|
|
|||
| flags.AddTxFlagsToCmd(cmd) | |||
|
|
|||
There was a problem hiding this comment.
[nit] unnecessary changes to this file
There was a problem hiding this comment.
Other commands in the same file had that statement next to the return, so I removed that empty line for consistency. I can revert it, if you want; have no strong preference...
There was a problem hiding this comment.
ah okay, no it's not a big deal at all!
There was a problem hiding this comment.
I actually kinda like the spaces, a little confusing why we format differently between query.go and tx.go
charleenfei
approved these changes
Sep 9, 2022
crodriguezvega
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
* add missing tx and query flags to cli * run gofumpt * remove adding tx flags (cherry picked from commit 2a46942)
This was referenced Sep 12, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
* add missing tx and query flags to cli * run gofumpt * remove adding tx flags (cherry picked from commit 2a46942)
crodriguezvega
added a commit
that referenced
this pull request
Sep 13, 2022
* add missing tx and query flags to cli * run gofumpt * remove adding tx flags (cherry picked from commit 2a46942) Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega
added a commit
that referenced
this pull request
Sep 14, 2022
* add missing tx and query flags to cli * run gofumpt * remove adding tx flags (cherry picked from commit 2a46942) Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes