Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gov proposal execution for e2e testsuite #2114

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

colin-axner
Copy link
Contributor

Description

See #2071 for passing test usage

closes: #2113


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Will we also need to support the new way of using gov proposal with v0.46?

@colin-axner
Copy link
Contributor Author

Will we also need to support the new way of using gov proposal with v0.46?

Yea I think so, but those won't be backwards compatible for cross compatibility testing, so we can add that function for future usage when we start migrating our proposals to messages. Essentially we will just have duplicates of legacy and new for a while until we remove legacy as those versions no longer become supported

@colin-axner colin-axner merged commit 8911d8d into main Aug 25, 2022
@colin-axner colin-axner deleted the colin/2113-execute-gov-prop-e2e branch August 25, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add function to execute gov proposals for e2e
3 participants