Update e2e go.mod #2022
Merged
Update e2e go.mod #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: compiling error. replace IBC module to the local, which is convenient for development
liangping
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
chatton
reviewed
Aug 17, 2022
e2e/go.mod
Outdated
| replace ( | ||
| github.com/ChainSafe/go-schnorrkel => github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d | ||
| github.com/ChainSafe/go-schnorrkel/1 => github.com/ChainSafe/go-schnorrkel v1.0.0 | ||
| github.com/cosmos/ibc-go/v5 => ../ |
There was a problem hiding this comment.
I'm a bit hesitant to pin this.
Currently, ibctest is pinned to v5, if we update to v6, the tests will fail due to a duplicate message registration with multiple ibc-go imports.
We're explicitly keeping it separate right now, but I think having this as a commented line at the bottom of the file would be very useful for development, i.e.
// uncomment to use the local version of ibc-go
// replace github.com/cosmos/ibc-go/v5 => ../`
There was a problem hiding this comment.
OK, Yeah, it's better.
add comment for local version
|
Hi @liangping, it looks like you'll need to run |
|
I did. |
|
Let me add it to the comment |
colin-axner
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: compiling error.
replace IBC module to the local, which is convenient for development
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes