Fix E2E Tests: Update ibctest (Cosmos SDK 0.46) #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bc-go into update-ibctest-sdk-0-46
chatton
changed the title
chatton
commented
Aug 10, 2022
Comment on lines
-312
to
-321
| s.T().Cleanup(func() { | ||
| if !s.T().Failed() { | ||
| for _, c := range []*cosmos.CosmosChain{chainA, chainB} { | ||
| if err := c.Cleanup(ctx); err != nil { | ||
| s.T().Logf("Chain cleanup for %s failed: %v", c.Config().ChainID, err) | ||
| } | ||
| } | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
the cleanup logic should be handled in ibctest now
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
chatton
commented
Aug 10, 2022
| ) | ||
|
|
||
| // TODO: using version v1.0.0 causes a build failure. This is the previous version which compiles successfully. | ||
| replace github.com/ChainSafe/go-schnorrkel => github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d |
There was a problem hiding this comment.
this is the same version used in ibc-go go.mod
Codecov Report
@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
+ Coverage 80.04% 80.12% +0.07%
==========================================
Files 166 167 +1
Lines 12421 11766 -655
==========================================
- Hits 9943 9428 -515
+ Misses 2013 1923 -90
+ Partials 465 415 -50
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit c304a7c) # Conflicts: # e2e/testsuite/testsuite.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit c304a7c) # Conflicts: # e2e/testsuite/testsuite.go
damiannolan
added a commit
that referenced
this pull request
Aug 24, 2022
* Fix E2E Tests: Update ibctest (Cosmos SDK 0.46) (#1949) (cherry picked from commit c304a7c) # Conflicts: # e2e/testsuite/testsuite.go * resolving conflicts Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
damiannolan
added a commit
that referenced
this pull request
Aug 24, 2022
* Fix E2E Tests: Update ibctest (Cosmos SDK 0.46) (#1949) (cherry picked from commit c304a7c) # Conflicts: # e2e/testsuite/testsuite.go * resolving conflicts Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the to the version of ibctest which uses the cosmos sdk 0.46, this should allow us to run E2E tests again.
closes #1870
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes