Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate checks in upgrade logic #182

Merged
merged 3 commits into from
May 24, 2021

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented May 20, 2021

Description

closes: #178


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@AdityaSripal AdityaSripal merged commit 0d01128 into main May 24, 2021
@AdityaSripal AdityaSripal deleted the colin/178-upgrade-audit-fixes branch May 24, 2021 14:05
faddat referenced this pull request in notional-labs/ibc-go Feb 23, 2022
Prevent contract funding from blocked addr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Audit Findings
2 participants