-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add consensus state heights query (backport #1336) #1506
chore: Add consensus state heights query (backport #1336) #1506
Conversation
* add ConsensusStateHeights query * add cli for ConsensusStateHeights Query * update CHANGELOG.md * Update modules/core/02-client/keeper/grpc_query.go Co-authored-by: Damian Nolan <[email protected]> * Update modules/core/02-client/client/cli/query.go Co-authored-by: Damian Nolan <[email protected]> * Update modules/core/02-client/client/cli/query.go Co-authored-by: Damian Nolan <[email protected]> * Update modules/core/02-client/client/cli/query.go Co-authored-by: Damian Nolan <[email protected]> * update consensus height query * very minor changes in modules/core/02-client grpc_query_test * Update modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Sean King <[email protected]> * Update modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Sean King <[email protected]> * Update modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Sean King <[email protected]> * Update modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Sean King <[email protected]> * Update modules/core/02-client/client/cli/query.go Co-authored-by: Sean King <[email protected]> * Update modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Carlos Rodriguez <[email protected]> * Update CHANGELOG.md Co-authored-by: colin axnér <[email protected]> * update swagger.yaml; update 02-client grpc_query_test * Update modules/core/02-client/keeper/grpc_query_test.go Co-authored-by: Damian Nolan <[email protected]> * nit Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Sean King <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: vuong <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 042d818) # Conflicts: # CHANGELOG.md # docs/client/swagger-ui/swagger.yaml # modules/core/02-client/keeper/grpc_query_test.go # modules/core/02-client/types/query.pb.go
@@ -36,6 +36,11 @@ service Query { | |||
option (google.api.http).get = "/ibc/core/client/v1/consensus_states/{client_id}"; | |||
} | |||
|
|||
// ConsensusStateHeights queries the height of every consensus states associated with a given client. | |||
rpc ConsensusStateHeights(QueryConsensusStateHeightsRequest) returns (QueryConsensusStateHeightsResponse) { | |||
option (google.api.http).get = "/ibc/core/client/v1/consensus_states/{client_id}/heights"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR had the route "/ibc/core/client/v1/consensus_states/heights/{client_id}"
, but I just realized that it would be more consistent with heights
at the end, so I changed it here. It's a bit sneaky, but I hope it's ok. I will also open a PR to main to update the route.
This is an automatic backport of pull request #1336 done by Mergify.
Cherry-pick of 042d818 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com