fix: cli params ordering ics29 #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
damiannolan
as code owners
seantking
commented
May 13, 2022
modules/apps/29-fee/client/cli/tx.go
Outdated
| @@ -101,10 +101,10 @@ func NewPayPacketFeeAsyncTxCmd() *cobra.Command { | |||
| // NewRegisterCounterpartyAddress returns the command to create a MsgRegisterCounterpartyAddress | |||
| func NewRegisterCounterpartyAddress() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "register-counterparty [address] [counterparty-address] [channel-id] [port-id]", | |||
| Use: "register-counterparty [address] [counterparty-address] [port-id] [channel-id]", | |||
There was a problem hiding this comment.
Should we maybe start with port-id & channel-id instead of the addresses?
There was a problem hiding this comment.
Good point... maybe yeah.
There was a problem hiding this comment.
Maybe let's start indeed with port-id and channel-id. That's the order we have for transfer: simd tx ibc-transfer transfer [src-port] [src-channel] [receiver] [amount].
crodriguezvega
approved these changes
May 13, 2022
colin-axner
approved these changes
May 16, 2022
damiannolan
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #(#1339 (comment))
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes