Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit ics29 events on cacheCtx write after refunding on closed channel #1344

Merged
merged 4 commits into from
May 11, 2022

Conversation

colin-axner
Copy link
Contributor

Description

closes: #1323


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #1344 (834e401) into main (dcd0681) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1344   +/-   ##
=======================================
  Coverage   80.28%   80.29%           
=======================================
  Files         166      166           
  Lines       12044    12047    +3     
=======================================
+ Hits         9670     9673    +3     
  Misses       1918     1918           
  Partials      456      456           
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/escrow.go 93.50% <100.00%> (+0.12%) ⬆️

@mergify mergify bot merged commit ab8ab42 into main May 11, 2022
@mergify mergify bot deleted the colin/1323-emit-events branch May 11, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit event in RefundFeesOnChannelClosure
5 participants