Add VerifyMembership to 07-tendermint #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Apr 25, 2022
damiannolan
approved these changes
Apr 26, 2022
…lin/1145-07-tendermint-generic
colin-axner
requested review from
fedekunze,
AdityaSripal,
crodriguezvega and
charleenfei
as code owners
5 tasks
|
ACK latest commits 👍 |
seantking
approved these changes
Apr 28, 2022
oshorefueled
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
* add VerifyMembership function and initial tests * revert unnecessary code changes * add rest of successful verify test cases * increase code coverage with additional tests * chore: remove field naming from test cases * add test case using VerifyMembership on non IBC store value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks @damiannolan for providing the initial changes
ref: #1291
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes