Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ics29 module housekeeping cleanup #1227

Merged
merged 3 commits into from
Apr 7, 2022
Merged

chore: ics29 module housekeeping cleanup #1227

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6decbbd
cleaning up comments and no-op funcs in module.go
damiannolan Apr 7, 2022
d0cdf09
Merge branch 'main' into damian/873-ics29-cleanup
damiannolan Apr 7, 2022
6af17f4
Merge branch 'main' into damian/873-ics29-cleanup
mergify[bot] Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions modules/apps/29-fee/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ import (
"github.com/cosmos/ibc-go/v3/modules/apps/29-fee/client/cli"
"github.com/cosmos/ibc-go/v3/modules/apps/29-fee/keeper"
"github.com/cosmos/ibc-go/v3/modules/apps/29-fee/types"

// "github.com/cosmos/ibc-go/v3/modules/apps/29-fee/client/cli"
// "github.com/cosmos/ibc-go/v3/modules/apps/29-fee/simulation"

porttypes "github.com/cosmos/ibc-go/v3/modules/core/05-port/types"
)

Expand Down Expand Up @@ -99,7 +95,6 @@ func NewAppModule(k keeper.Keeper) AppModule {

// RegisterInvariants implements the AppModule interface
func (AppModule) RegisterInvariants(ir sdk.InvariantRegistry) {
// TODO
}

// Route implements the AppModule interface
Expand Down Expand Up @@ -154,7 +149,7 @@ func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.V
// AppModuleSimulation functions

// GenerateGenesisState creates a randomized GenState of the 29-fee module.
func (AppModule) GenerateGenesisState(simState *module.SimulationState) {
func (AppModule) GenerateGenesisState(_ *module.SimulationState) {
}

// ProposalContents doesn't return any content functions for governance proposals.
Expand All @@ -163,14 +158,12 @@ func (AppModule) ProposalContents(_ module.SimulationState) []simtypes.WeightedP
}

// RandomizedParams creates randomized ibc-29-fee param changes for the simulator.
func (AppModule) RandomizedParams(r *rand.Rand) []simtypes.ParamChange {
// return simulation.ParamChanges(r)
func (AppModule) RandomizedParams(_ *rand.Rand) []simtypes.ParamChange {
return nil
}

// RegisterStoreDecoder registers a decoder for 29-fee module's types
func (am AppModule) RegisterStoreDecoder(sdr sdk.StoreDecoderRegistry) {
// sdr[types.StoreKey] = simulation.NewDecodeStore(am.keeper)
func (am AppModule) RegisterStoreDecoder(_ sdk.StoreDecoderRegistry) {
}

// WeightedOperations returns the all the 29-fee module operations with their respective weights.
Expand Down