call packet.GetSequence() rather than passing the func as argument (backport #1130) #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
colin-axner,
fedekunze,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
damiannolan
approved these changes
Mar 18, 2022
colin-axner
approved these changes
Mar 21, 2022
ellie4x
pushed a commit
to Carina-labs/ibc-go
that referenced
this pull request
Sep 14, 2022
…ackport cosmos#1130) (cosmos#1139) * call packet.GetSequence() rather than passing the func as argument (cosmos#1130) * call packet.GetSequence() rather than passing the func as argument * add changelog entry (cherry picked from commit dbd2df2) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: Carlos Rodriguez <[email protected]>
dudong2
pushed a commit
to dudong2/ibc-go
that referenced
this pull request
Jan 19, 2023
…ackport cosmos#1130) (cosmos#1139) * call packet.GetSequence() rather than passing the func as argument (cosmos#1130) * call packet.GetSequence() rather than passing the func as argument * add changelog entry (cherry picked from commit dbd2df2) * fix conflicts Co-authored-by: Carlos Rodriguez <[email protected]>
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview When I follow the instructions here: https://rollkit.dev/tutorials/gm-world#macos-setup, I encountered the following error: ``` github.com/cosmos/cosmos-sdk/server imports github.com/rollkit/rollkit/node imports github.com/rollkit/rollkit/mempool/v1 imports github.com/cometbft/cometbft/abci/example/code: package github.com/cometbft/cometbft/abci/example/code provided by github.com/cometbft/cometbft at latest version v0.37.2 but not at required version v0.38.0-rc2 ``` Then I finally found package `github.com/cometbft/cometbft/abci/example/code` has been removed. Use the code defined in the abci types instead. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1130 done by Mergify.
Cherry-pick of dbd2df2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com