Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes for v2 to v3 migration #1016

Merged
merged 6 commits into from
Mar 4, 2022
Merged

small fixes for v2 to v3 migration #1016

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d39d47d
small fixes for v2 to v3 migration
crodriguezvega Feb 28, 2022
1c9adf7
review comment
Feb 28, 2022
71e3db2
Merge branch 'main' into carlos/migration-docs-fixes
crodriguezvega Mar 1, 2022
ae82168
Update v2-to-v3.md
crodriguezvega Mar 1, 2022
413f8c5
Merge branch 'main' into carlos/migration-docs-fixes
crodriguezvega Mar 3, 2022
bc4ef1d
add store upgrade documentation
Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/migrations/v2-to-v3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ app.UpgradeKeeper.SetUpgradeHandler("v3",
func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
// set the ICS27 consensus version so InitGenesis is not run
fromVM[icatypes.ModuleName] = icamodule.ConsensusVersion()


// create ICS27 Controller submodule params
controllerParams := icacontrollertypes.Params{
Expand All @@ -46,7 +45,7 @@ app.UpgradeKeeper.SetUpgradeHandler("v3",
// create ICS27 Host submodule params
hostParams := icahosttypes.Params{
HostEnabled: true,
AllowMessages: []string{"/cosmos.bank.v1beta1.MsgSend", ...],
AllowMessages: []string{"/cosmos.bank.v1beta1.MsgSend", ...},
}

// initialize ICS27 module
Expand Down Expand Up @@ -79,7 +78,7 @@ The migration code required may look like:
// overwrite parameters as desired
hostGenesisState.Params = icahosttypes.Params{
HostEnabled: true,
AllowMessages: []string{"/cosmos.bank.v1beta1.MsgSend", ...],
AllowMessages: []string{"/cosmos.bank.v1beta1.MsgSend", ...},
}

icaGenesisState := icatypes.NewGenesisState(controllerGenesisState, hostGenesisState)
Expand Down