Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet acknowledgement logging incorrectly passes getSequence() function rather than calling #994

Closed
3 tasks
joe-bowman opened this issue Feb 23, 2022 · 0 comments · Fixed by #995
Closed
3 tasks

Packet acknowledgement logging incorrectly passes getSequence() function rather than calling #994

joe-bowman opened this issue Feb 23, 2022 · 0 comments · Fixed by #995

Comments

@joe-bowman
Copy link

Summary of Bug

L495 of channel-04/keeper/packet.go emits a log message regarding the acknowledgement of a packet.

L497 incorrectly passes packet.GetSequence, rather than calling packet.GetSequence(), meaning the value of sequence in the log output is a JSON marshalling error as follows:

quicksilver_1  | 10:02PM INF packet acknowledged dst_channel=channel-1 dst_port=icahost module=x/ibc/channel sequence="marshaling error: json: unsupported type: func() uint64" src_channel=channel-1 src_port=icacontroller-test-2.deposit

Version

v2.0.3 onwards

Steps to Reproduce

N/A

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@joe-bowman joe-bowman mentioned this issue Feb 23, 2022
Merged
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tuxcanfly
da: add celestia-openrpc dep (cosmos#994)
91dc413 
## Overview

This PR adds a dependency on `celestia-openrpc` `505ff801e818` which
will eventually replace `go-cnc`. `go-header` was pinned to `0.2.6` as
`0.2.7` is breaking tests.

Fixes cosmos#995 

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

call packet.GetSequence() rather than passing the func as argument ingenuity-build/ibc-go
1 participant
@joe-bowman