Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof missing in ClientState response from grpc_query #97

Closed
3 tasks
sahith-narahari opened this issue Mar 29, 2021 · 2 comments
Closed
3 tasks

Proof missing in ClientState response from grpc_query #97

sahith-narahari opened this issue Mar 29, 2021 · 2 comments

Comments

@sahith-narahari
Copy link

Summary of Bug

Using cli to query ClientState has the ability to return the proof whereas grpc returns only clientState and proofHeight.

I'm trying to use the grpc to query clientState and proof but proof seems to be missing. I see the cli uses different function rather than the grpc query. Is it possible to also return the proof using grpc?

Version

main

372eaa42a9082bcbeaca344fc41151ab95f8b5cd

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

colin-axner commented Mar 30, 2021

gRPC doesn't support proof generation since it directly accesses the value from the Keeper. There is a tracking issue on the SDK. Would love to see someone investigate potential solutions to fix this issue

ABCI queries support proof generation, but it is generally advised to use the QueryTendermintProof helper function. Otherwise you need to account for tendermint's delayed execution model

@sahith-narahari
Copy link
Author

Thanks for the clarification

faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
* WIP Update to latest work

* Update to latest sdk version
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
)

* add a validator to pubsub and remove the routine that gossips mempool messages

* broadcast new transactions submitted to the node

* linter has no chill

* refactor tx validator to use mempool's CheckTx method

Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Tomasz Zdybał <[email protected]>

* only gossip valid transactions

Co-authored-by: Tomasz Zdybał <[email protected]>

* thanks linter

* update the mempool interface to accomodate removing txs

* add missed comment

* fix data race

* use errors.Is and revert changing ErrTxInCache to it's own type

Co-authored-by: Ismail Khoffi <[email protected]>

* include a bad transaction in the mempool test

* better document the reasoning behind gossiping in the local rpcclient package

* correct copy past docs

* add extra test to ensure that the same tx cannot be broadcast twice

* go mod tidy and fix merge conflicts

Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Tomasz Zdybał <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants