Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid denom cannot be sent via IBC #894

Closed
giansalex opened this issue Feb 9, 2022 · 2 comments · Fixed by #978
Closed

Valid denom cannot be sent via IBC #894

giansalex opened this issue Feb 9, 2022 · 2 comments · Fixed by #978
Assignees
Labels
type: bug Something isn't working as expected

Comments

@giansalex
Copy link

gamm/pool/1 is a valid denom, ref: sdk validation
but I am getting an error when I try to send it through IBC.

code: 3
codespace: transfer
data: ""
gas_used: "0"
gas_wanted: "0"
height: "0"
info: ""
logs: []
raw_log: 'denomination should be prefixed with the format ''ibc/{hash(trace + "/"
  + gamm/pool/1)}'': invalid denomination for cross-chain transfer'
timestamp: ""
tx: null
txhash: CD4305E38FDDC054B64B8F076DD860AD431EA56E456FE4EF16272571381D1FB8
@crodriguezvega
Copy link
Contributor

Thanks for opening this issue, @giansalex.

Looks like we assume that base denominations do not contain /s. If a / is present in the denom, then we always expect that the denom is for an IBC fungible token and has the ibc prefix.

Looks like this would be a bug, but I would like a confirmation also from @colin-axner.

@colin-axner
Copy link
Contributor

Yea that's a bug. We can change it. Appears that validation function is only used in MsgTransfer anyways. I'm not exactly sure if we even need any of the extra validation in that function. Ensuring it is a valid SDK denom should be good enough

@crodriguezvega crodriguezvega added the type: bug Something isn't working as expected label Feb 10, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Feb 10, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Feb 20, 2022
@crodriguezvega crodriguezvega self-assigned this Feb 20, 2022
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Feb 23, 2022
Repository owner moved this from In review to Done in ibc-go Feb 28, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
… with go-fraud Proof interface (cosmos#891)

As part of go-fraud library implementation, this PR adds:
* ProofService to full and light nodes
* Extends abci.FraudProof interface with go-fraud Proof interface

Fixes cosmos#892 cosmos#893 cosmos#894

---------

Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants