Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test ensuring optimstic packet sends are not allowed on ics27 #784

Closed
3 tasks
colin-axner opened this issue Jan 24, 2022 · 0 comments · Fixed by #842
Closed
3 tasks

Add test ensuring optimstic packet sends are not allowed on ics27 #784

colin-axner opened this issue Jan 24, 2022 · 0 comments · Fixed by #842
Assignees
Labels
27-interchain-accounts testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

core IBC allows packets to be sent optimistically. That is, a packet can be send on a connection and channel in INIT. ics27 currently disallows this since an active channel needs to be created (requiring ACK handshake step). I think this is the correct decision for v1 of interchain accounts (potentially an optional feature later). We should add a test which verifies this. That what if we modify the ics27 implementation to remove the notion of active channels, we will be forced to revisit this discussion and come to an explicit decision instead of accidentally allowing optimistic sends due to oversight


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests 27-interchain-accounts labels Jan 24, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 24, 2022
@colin-axner colin-axner added this to the Interchain Accounts milestone Jan 25, 2022
@colin-axner colin-axner moved this from Backlog to Todo in ibc-go Feb 2, 2022
@damiannolan damiannolan self-assigned this Feb 3, 2022
Repository owner moved this from Todo to Done in ibc-go Feb 3, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
…ation in validate method (cosmos#788)

Fixes cosmos#782 cosmos#783 cosmos#784

---------

Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts testing Testing package and unit/integration tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants