Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize logging to stdout #322

Closed
3 tasks
colin-axner opened this issue Aug 9, 2021 · 0 comments
Closed
3 tasks

Minimize logging to stdout #322

colin-axner opened this issue Aug 9, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Aug 9, 2021

Summary

Currently in SendPacket we log the entire packet being sent, this might look like:

11:07AM INF packet sent module=x/ibc/channel packet="{3298 transfer channel-4 transfer channel-6 [123 34 97 109 111 117 110 116 34 58 34 50 51 53 48 54 55 53 48 52 34 44 34 100 101 110 111 109 34 58 34 116 114 97 110 115 102 101 114 47 99 104 97 110 110 101 108 45 52 47 117 120 112 114 116 34 44 34 114 101 99 101 105 118 101 114 34 58 34 112 101 114 115 105 115 116 101 110 99 101 49 122 122 114 103 50 101 107 52 122 101 53 115 99 100 117 51 54 120 101 99 102 101 99 57 116 50 108 117 54 110 104 118 117 104 116 56 54 107 34 44 34 115 101 110 100 101 114 34 58 34 111 115 109 111 49 118 117 50 55 53 117 51 120 50 114 122 99 107 115 117 116 122 119 113 54 118 54 100 103 109 48 108 120 115 122 113 118 102 100 106 108 107 55 34 125] 1-1995511 0}"

on the logs. The packet data could potentially be a security vulnerability. It also provides little use when printed to the logs. We should instead update these logs to only print that a packet is being sent with a certain sequence on a certain source port/channel. Destination port/channel are optional as they can always be queried since every source port/channel is associated with a destination port/channel. It might be useful to log the timeouts as well, the packet data can be left off

Applications such as transfer, may then log state changes triggered by packet send, such as escrowing/burning tokens

We should audit all our logs to ensure we aren't dumping unnecessary information


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the good first issue Good for newcomers label Aug 9, 2021
@colin-axner colin-axner added this to the 1.1.0 milestone Aug 9, 2021
@crodriguezvega crodriguezvega self-assigned this Aug 11, 2021
@crodriguezvega crodriguezvega modified the milestones: 1.1.0, vNext Sep 17, 2021
@crodriguezvega crodriguezvega modified the milestones: vNext, v2.0.a Jan 5, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
Handle panics in query contract smart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants