Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add export genesis tests #243

Open
3 tasks
colin-axner opened this issue Jul 7, 2021 · 2 comments
Open
3 tasks

add export genesis tests #243

colin-axner opened this issue Jul 7, 2021 · 2 comments
Labels
testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

we need tests which ensure that all the genesis fields are exported and that the exported genesis is valid


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Jul 7, 2021
@fedekunze
Copy link
Contributor

fedekunze commented Jul 7, 2021

have you considered using the new in-store migrations instead?

@colin-axner
Copy link
Contributor Author

have you considered using the new in-store migrations instead?

yup! Already implemented that in #205. Unfortunately we should keep genesis upgrades around as a backup solution. As it stands, it isn't possible to change the chain id just via an x/upgrade since tendermint loads the chain id from the gen doc and doesn't expose a way to change it block to block

Supporting genesis upgrades is a lot of work and the process is clumsy at best, but if for some reason something goes wrong with x/upgrade or a chain id must be incremented, it is nice knowing there's always a backup option available

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
* feat: ConsensusState/DumpConsensusState implementation

Resolves cosmos#242
Resolves cosmos#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests
Projects
None yet
Development

No branches or pull requests

2 participants