Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait for packet to be relayed function to e2e tests #1981

Open
3 tasks
colin-axner opened this issue Aug 11, 2022 · 1 comment
Open
3 tasks

Add wait for packet to be relayed function to e2e tests #1981

colin-axner opened this issue Aug 11, 2022 · 1 comment
Labels

Comments

@colin-axner
Copy link
Contributor

Summary

While writing the e2e tests for ics20, I noticed the relayer did not relay my packets before the next assertion came. This issue was solved by adding a .waitForBlocks call. Several blocks were required to be waited on. Instead of waiting for enough blocks to be committed for the relayer to relay the packet, we should wait on the packet to be relayed by. I guess this can be done by waiting for a block to be committed and then querying to see if the packet was relayed, otherwise wait for the next block. Any other ideas?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Aug 11, 2022
@crodriguezvega crodriguezvega added e2e and removed testing Testing package and unit/integration tests labels Aug 18, 2022
@chatton
Copy link
Contributor

chatton commented Aug 19, 2022

I think we could generalize this one step further and simply have a WaitForCondition(func() (bool, error)). This should be quite flexible and let us wait for arbitrary conditions to be met. We would also need to specify a timeout and some sort of polling interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants