Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update or remove OLD_README.md #134

Closed
1 task
AdityaSripal opened this issue Apr 22, 2021 · 3 comments
Closed
1 task

Update or remove OLD_README.md #134

AdityaSripal opened this issue Apr 22, 2021 · 3 comments
Labels
docs Improvements or additions to documentation

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Apr 22, 2021 •
edited
Loading

It's worth double checking rest of links and adding them here as TODOs
@colin-axner colin-axner added the docs Improvements or additions to documentation label Apr 22, 2021
@colin-axner colin-axner added this to the 1.0.1 milestone Apr 22, 2021
@colin-axner colin-axner changed the title Broken Links Update or remove OLD_README.md Jul 13, 2021
@colin-axner
Copy link
Contributor

OLD_README.md in docs/ has many broken links. It should be updated and used for some purpose or removed entirely

@albertchon
Copy link

The code comments also have many broken links. One can easily just search github.com/cosmos/ics and see a lot of the outdated links

@crodriguezvega crodriguezvega modified the milestones: 1.1.0, vNext Sep 17, 2021
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega
Copy link
Contributor

Closed by #2898.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@jbowen93
Change mock implementation to use store.KVStore instead of maps (cos…
59ab23b 
…mos#146)

* update `MockDataAvailabilityLayerClient` to use `KVStore` instead of maps
* ensure that `KVStore` is passed to `Init` in the tests

Resolves cosmos#134.
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Change mock implementation to use store.KVStore instead of maps
eea0a82 
* update `MockDataAvailabilityLayerClient` to use `KVStore` instead of maps
* ensure that `KVStore` is passed to `Init` in the tests

Resolves cosmos#134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crodriguezvega @AdityaSripal @albertchon @colin-axner