Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CheckMisbehaviourAndUpdateState from the ClientState interface #1189

Closed
3 tasks
colin-axner opened this issue Mar 29, 2022 · 0 comments
Closed
3 tasks

Remove CheckMisbehaviourAndUpdateState from the ClientState interface #1189

colin-axner opened this issue Mar 29, 2022 · 0 comments
Labels
02-client
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

Following #668 and #1188, we can remove CheckMisbehaviourAndUpdateState from the client state interface. It can be removed from each of the light clients as well

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner changed the title Remove CheckMisbehaviourAndUpdateState Remove CheckMisbehaviourAndUpdateState from the ClientState interface Mar 29, 2022
@colin-axner colin-axner moved this to Todo in ibc-go Mar 29, 2022
@colin-axner colin-axner moved this from Todo to On hold in ibc-go Mar 29, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
@seantking seantking mentioned this issue Apr 4, 2022
Merged
9 tasks
Repository owner moved this from On hold to Done in ibc-go Apr 4, 2022
@colin-axner colin-axner mentioned this issue Apr 21, 2022
Closed
3 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
Decouple TestVerify into TestValidateBasic and TestVerify (cosmos#1231)
0f49204 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: cosmos#1189 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02-client
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor alpha
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner