-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic state verification functions to ClientState interface #1145
Comments
For the solo machine implementation, to avoid being blocked by #1141, a switch case should be used on the provided path. If the path matches a supported type then the sign bytes can be constructed, otherwise an error should be returned. The implementation of #1141 will extend the generic verify functions for the solomachine to accept any path |
I have a WIP branch for this from a few weeks ago so will self-assign! |
I can do the 07-tendermint changes |
## Overview This PR improves upon cosmos#1144 by simplifying `mock.Server` to use `httptest` directly, avoiding a duplicate `http.Server`. `Server.Start` doesn't need a listener anymore, and it returns the URL at which the `httptest.Server` is running. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Summary
Add two new generic state verification functions to the
ClientState
interface.VerifyMembership
VerifyNonMembership
ref: cosmos/ibc#687
Proposal
Separate PRs can be made to split up the work:
VerifyMembership
andVerifyNonMembership
toClientState
interface06-solomachine
implementation07-tendermint
implementation09-localhost
implementationFor Admin Use
The text was updated successfully, but these errors were encountered: