You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running make proto-all fails with protobuf lint error: "Enum value name \"...\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."
Steps to Reproduce
make proto-all
Formatting Protobuf files
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":50,"start_column":3,"end_line":50,"end_column":30,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_UNSPECIFIED\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":52,"start_column":3,"end_line":52,"end_column":23,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_NOOP\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":54,"start_column":3,"end_line":54,"end_column":26,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_SUCCESS\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
make: *** [proto-lint] Error 100
Proposal
Update the ResponseResultType enums to include _TYPE in the prefix.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes: cosmos#884
Applies the fix described in
rollkit/rollkit#884 (comment) -
update the store height before pushing the block to DA so that the store
height accessed in `trySyncNextBlock` is updated.
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
## Checklist
<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.
IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->
- [x] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Summary of Bug
Running
make proto-all
fails with protobuf lint error:"Enum value name \"...\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."
Steps to Reproduce
Proposal
Update the
ResponseResultType
enums to include_TYPE
in the prefix.For Admin Use
The text was updated successfully, but these errors were encountered: