chore: cleanup unnecessary ndb.Commit calls (backport #902)
#921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit 5a9cc69)
cool-develope
approved these changes
Mar 22, 2024
|
I can give this a try against Osmosis mainnet once you confirm the test failure is non issue! (of course feel free to merge without me testing against Osmosis, just wanted to offer the reassurance of a test) |
appreciate if you test against the live chain. The test is flaky due to the legacy node pruning |
|
Setting up now! |
|
@cool-develope tested against mainnet for 1k blocks and so far so good! |
|
Okay have run quite a few blocks, should be good to go |
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There are some unnecessary
ndb.CommitandresetBatchcalls which introduced to avoid the large batch commit originally. They are not necessary since we are usingBatchWithFlushernow.This is an automatic backport of pull request #902 done by Mergify.