refactor: Drop error results from functions that never fail #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no cases where Hash would fail, so don't return an error value. Simplifies every caller, as can be seen from the test changes. Fixes cosmos#757
The byte buffer in Node.hashWithCount is not necessary because the hash.Hash interface implements io.Writer. Use that directly instead to save allocations and memory.
There's no need because the hashing can never fail.
elias-orijtech
changed the title
|
could we get a changelog for the api break also linting is failing |
Tree construction never fails, so don't return an error. Fixes cosmos#756
Done. |
|
could we fix the linting issues as well please |
elias-orijtech
added a commit
to elias-orijtech/iavl
that referenced
this pull request
May 30, 2023
Found by the linter in cosmos#777
Merged
elias-orijtech
added a commit
to elias-orijtech/iavl
that referenced
this pull request
May 30, 2023
Found by the linter in cosmos#777. Remove an unused linter directive while here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashing procedure can never fail, and not returning an error frees up callers from worrying about it.
Also includes a performance optimization.
Fixes #757.
Fixes #756.
CC @odeke-em