dep: update tm-db to latest release #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Baricevic <[email protected]>
tac0turtle
commented
Jan 8, 2020
melekes
reviewed
Jan 8, 2020
melekes
reviewed
Jan 10, 2020
melekes
reviewed
Jan 10, 2020
melekes
reviewed
Jan 13, 2020
| rootHash := tree.ndb.getRoot(targetVersion) | ||
| rootHash, err := tree.ndb.getRoot(targetVersion) | ||
| if err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
so here is the question: at which point we should retry DB operation (say 5 times) before bubbling up an error to the caller?
There was a problem hiding this comment.
in my view, I would prefer the application to handle this and here we present the error each time. @alexanderbez do you have a preference. The sdk is the main user of this repo so your preference matters most
There was a problem hiding this comment.
This change looks fine and behaves as I'd expect. If the version provided cannot be fetched, then the upstream caller should handle that error (either retry another version or fail completely).
There was a problem hiding this comment.
Agree. My question of course goes beyond this case.
melekes
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic [email protected]