chore: remove double registration warning (#67)

cosmos · May 11, 2023 · 28c37ed · 28c37ed
1 parent 413865a
commit 28c37ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## [v1.4.10](https://github.com/cosmos/gogoproto/releases/tag/v1.4.10) - 2023-05-11
+
+- [#67](https://github.com/cosmos/gogoproto/pull/67) Remove warning about double registration. The Cosmos SDK does purposely double-registration so this warning is not useful.
+
 ## [v1.4.9](https://github.com/cosmos/gogoproto/releases/tag/v1.4.9) - 2023-05-03
 
 ### Breaking changes

diff --git a/proto/properties.go b/proto/properties.go
@@ -651,13 +651,12 @@ func RegisterFile(filename string, fileDescriptor []byte) {
 	// only register files if they are registered the first time
 	// this isn't ideal, but it's needed to make tests pass and some legacy
 	// code bases may have this issue, and we don't want to fail them here
+	// when the file is already registered, no warning is displayed.
 	if _, err := gogoProtoRegistry.FindFileByPath(file.Path()); err != nil {
 		err = gogoProtoRegistry.RegisterFile(file)
 		if err != nil {
 			panic(err)
 		}
-	} else {
-		fmt.Printf("WARNING: proto: file %q already registered\n", file.Path())
 	}
 }