-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/for v5.0.7 #999
Backport/for v5.0.7 #999
Conversation
Codecov Report
@@ Coverage Diff @@
## release/v5.0.x #999 +/- ##
=================================================
Coverage ? 11.59%
=================================================
Files ? 11
Lines ? 966
Branches ? 0
=================================================
Hits ? 112
Misses ? 849
Partials ? 5 |
This is not compatible with existing cosmoshub-4 versions - most likely the antehandler change I suspect - previous versions are accepting multiple IBC handlers. This should minimally be 5.1.0, not 5.0.7. (for reference, I got an apphash mismatch about 4 blocks after restarting the chain with this version).
|
this might be due to the newest release of v5.0.6 is not on the branch of v5.0.x. I think we need fix branch first and rebase this branch in this pull request. (not so sure this will solve the app hash mismatch) |
It is the antehandler change; v5.0.6 + ask v0.42.10 (with iavl fixes) works
a treat (I'm running it in prod as of last night)
…On Thu, 30 Sep 2021, 10:46 yaruwangway, ***@***.***> wrote:
this might be due to the newest release of v5.0.6 is not on the branch of
v5.0.x. I think we need fix branch first and rebase this branch in this
pull request. (not so sure this will solve the app hash mismatch)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#999 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA7QYAVL3RHY7V6SIBS65LUEQWVTANCNFSM5FADCTCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Hi @joe-bowman, thanks! Releasing v5.1.0 makes sense! |
2f9cd3a
to
d5133e5
Compare
closing this in light of releasing |
Closes: #879
Description
Backport:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)