Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security process #761

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add Security process #761

merged 1 commit into from
Mar 12, 2021

Conversation

shahankhatch
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zmanian
Copy link
Member

zmanian commented Mar 12, 2021

Thank you for writing this up!

@shahankhatch shahankhatch merged commit 2adad56 into main Mar 12, 2021
@shahankhatch shahankhatch deleted the shahan/security_doc branch March 12, 2021 16:26
mergify bot pushed a commit that referenced this pull request Mar 13, 2021
(cherry picked from commit 2adad56)
@mergify mergify bot mentioned this pull request Mar 13, 2021
shahankhatch added a commit that referenced this pull request Mar 13, 2021
(cherry picked from commit 2adad56)

Co-authored-by: Shahan Khatchadourian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants