Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to join-mainnet.md #681

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Updates to join-mainnet.md #681

merged 1 commit into from
Feb 22, 2021

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Feb 22, 2021

Description

Adds an instant-gratification code snipped to join-mainnet.md

We may wish to briefly discuss the file's other contents before merging, I removed obviously outdated information so far.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@shahankhatch shahankhatch merged commit d6cb0e1 into cosmos:main Feb 22, 2021
@shahankhatch
Copy link
Contributor

Merged before seeing your phrase 'We may wish to briefly discuss the file's other contents before merging'. Apologies!

@faddat
Copy link
Contributor Author

faddat commented Feb 27, 2021

@shahankhatch it's okay, I think it'll work out fine :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants