Show branch and commit instead of tag when not on release branch #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahankhatch
requested review from
alessio,
alexanderbez,
fedekunze,
jgimeno and
zmanian
as code owners
alessio
reviewed
Feb 18, 2021
zmanian
approved these changes
Feb 18, 2021
alessio
approved these changes
Feb 19, 2021
shahankhatch
added a commit
that referenced
this pull request
Feb 19, 2021
shahankhatch
added a commit
that referenced
this pull request
Feb 19, 2021
shahankhatch
added a commit
that referenced
this pull request
Feb 19, 2021
11 tasks
alessio
pushed a commit
that referenced
this pull request
Mar 4, 2021
Most users run builds on tags and not on release branches. Because of a regression introduced in 651f646, the buildsystem is now assuming that the opposite is true, therefore it is longer capable to handle version strings correctly. Don't use git describe --tags to avoid relying on non-annotated tags. BRANCH name detection is ephemeral and unreliable, and should always be used only as last resort. Ref: #651
alessio
pushed a commit
that referenced
this pull request
Mar 4, 2021
Most users run builds on tags and not on release branches. Because of a regression introduced in 651f646, the buildsystem is now assuming that the opposite is true, therefore it is longer capable to handle version strings correctly. Don't use git describe --tags to avoid relying on non-annotated tags. BRANCH name detection is ephemeral and unreliable, and should always be used only as last resort. Ref: #651
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #627
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)