Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for bump of gogo protobuf to v1.3.3 #554

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

shahankhatch
Copy link
Contributor

@shahankhatch shahankhatch commented Jan 19, 2021

Depends on #555

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #554 (f62d249) into main (e226219) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   11.58%   11.58%           
=======================================
  Files           8        8           
  Lines         673      673           
=======================================
  Hits           78       78           
  Misses        586      586           
  Partials        9        9           

@shahankhatch shahankhatch merged commit aa8fb42 into main Jan 19, 2021
@shahankhatch shahankhatch deleted the shahan/changelog_bump_gogo_protobuf branch January 19, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants