Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against cosmos/cosmos-sdk@5889 #338

Closed
wants to merge 4 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 30, 2020

Test against cosmos/cosmos-sdk#5889


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #338 into master will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   67.65%   68.05%   +0.39%     
==========================================
  Files           4        4              
  Lines         504      504              
==========================================
+ Hits          341      343       +2     
+ Misses        132      130       -2     
  Partials       31       31              

@alessio alessio closed this Apr 7, 2020
@alessio alessio deleted the alessio/deprecate-lazy-keybase branch April 7, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant