Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cometbft) Prevent panic on non-nil proposal without vote extensions (backport #3270) #3280

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 19, 2024

Description

We saw that gaiad has adoped cometbft v0.38 "HEAD" but we are aware of a panic bug affecting validator nodes.

We first experienced daemon panics on seda chain due to cometbft v0.38.6 calling panic when a non-nil proposal vote has vote extensions disabled.

The panic is a mistake and cometbft v0.38.11 includes our fix.

This panic is likely to affect gaiad regardless of vote extensions being enabled or not since the bug is:

extSignature = len([]byte{}) > 0 = false
precommit = true
isNil = false

if extSignature == (!precommit || isNil) => if faise == (!true || false) => if false == (false || false) => if false == false {
 panic()
}

Link to cometbft PR and discussion:
cometbft/cometbft#3565

This fix can reduce gaiad panics on upcoming mainnet v19


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

This is an automatic backport of pull request #3270 done by [Mergify](https://mergify.com).

…ns (#3270)

* fix(cometbft) Prevent panic on non-nil proposal without vote extensions

* Update changelog files for PR 3270 feedback

Co-authored-by: Marius Poke <[email protected]>

---------

Co-authored-by: Marius Poke <[email protected]>
(cherry picked from commit c5ff8d2)
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for v9.1.0 to be cut before merging this.

@mpoke
Copy link
Contributor

mpoke commented Aug 21, 2024

closing as v19.1.0 already has this version of comet as a result of 92a2a88.

@mpoke mpoke closed this Aug 21, 2024
@mergify mergify bot deleted the mergify/bp/release/v19.1.x/pr-3270 branch August 21, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants