fix(cometbft) Prevent panic on non-nil proposal without vote extensions (backport #3270) #3280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We saw that gaiad has adoped cometbft v0.38 "HEAD" but we are aware of a panic bug affecting validator nodes.
We first experienced daemon panics on seda chain due to cometbft v0.38.6 calling panic when a non-nil proposal vote has vote extensions disabled.
The panic is a mistake and cometbft v0.38.11 includes our fix.
This panic is likely to affect gaiad regardless of vote extensions being enabled or not since the bug is:
Link to cometbft PR and discussion:
cometbft/cometbft#3565
This fix can reduce gaiad panics on upcoming mainnet v19
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog
(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeThis is an automatic backport of pull request #3270 done by [Mergify](https://mergify.com).