-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump SDK to v0.47.13-ics-lsm #3078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
April 22, 2024 13:10
MSalopek
previously approved these changes
Apr 22, 2024
MSalopek
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important note:
We needed to add a mod replace for golang.org/x/exp
so cosmos-sdk v0.47 keeps working as expected.
// stick with compatible version or x/exp in v0.47.x line
// x/exp had a breaking change in further commits
golang.org/x/exp => golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb
p-offtermatt
approved these changes
Apr 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* bump SDK to v0.47.13-ics-lsm * add changelog entries * fix: add expo replace directive --------- Co-authored-by: MSalopek <[email protected]> (cherry picked from commit 4d67e48) # Conflicts: # .changelog/v16.0.0/dependencies/3062-bump-sdk.md # .changelog/v16.0.0/dependencies/3078-bump-comet.md # .changelog/v16.0.0/dependencies/3078-bump-sdk.md # .changelog/v16.0.0/state-breaking/3062-bump-sdk.md # go.mod # go.sum
8 tasks
mpoke
added a commit
that referenced
this pull request
Apr 23, 2024
* chore(deps): bump SDK to v0.47.13-ics-lsm (#3078) * bump SDK to v0.47.13-ics-lsm * add changelog entries * fix: add expo replace directive --------- Co-authored-by: MSalopek <[email protected]> (cherry picked from commit 4d67e48) # Conflicts: # .changelog/v16.0.0/dependencies/3062-bump-sdk.md # .changelog/v16.0.0/dependencies/3078-bump-comet.md # .changelog/v16.0.0/dependencies/3078-bump-sdk.md # .changelog/v16.0.0/state-breaking/3062-bump-sdk.md # go.mod # go.sum * fix changelog * fix changelog * fix conflict --------- Co-authored-by: Marius Poke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Bump SDK to v0.47.13-ics-lsm (includes fixes from v0.47.11). It also bumps CometBFT to v0.37.5.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...