fix!: update gov MaxMetadataLen
#3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doggystylez
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
doggystylez
changed the title
MaxMetadataLenMaxMetadataLen
MSalopek
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Thank you for your contribution!
Could you link to the code line that defined this value in old gaia versions (or cosmos-sdk versions)?
On v47 it seems that all text fields are subject to the same assertions which may be a bit too strict:
Providing more context:
On cosmos-sdk v0.47 you can submit text proposals via gaiad tx gov submit-legacy-proposal (the "old" text proposals) and via gaiad tx gov submit-proposal.
Both ways of submitting proposals are affected.
MSalopek
approved these changes
Mar 28, 2024
MSalopek
added
A:backport/v15.1.x
type: bug
mpoke
approved these changes
Mar 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Co-authored-by: Philip Offtermatt <[email protected]> (cherry picked from commit c908e4b)
18 tasks
MSalopek
pushed a commit
that referenced
this pull request
Mar 29, 2024
Co-authored-by: Philip Offtermatt <[email protected]> (cherry picked from commit c908e4b) Co-authored-by: doggystylez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
in the recent sdk version upgrade, the metadeta length for gov props was set to default 255, which affects the description field for legacy (and new?) proposals. see:
https://www.mintscan.io/cosmos/proposals/893
https://www.mintscan.io/cosmos/proposals/895
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change