Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove GovPreventSpamDecorator #2913

Merged
merged 6 commits into from
Feb 1, 2024
Merged

fix!: remove GovPreventSpamDecorator #2913

merged 6 commits into from
Feb 1, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Jan 30, 2024

Description

Closes: #2911

Remove GovPreventSpamDecorator as this logic is already implemented in SDK 0.47, see https://github.com/cosmos/cosmos-sdk/blob/v0.47.8/x/gov/keeper/msg_server.go#L32.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke marked this pull request as ready for review January 30, 2024 11:01
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remap errors, other than that LGTM

types/errors/errors.go Outdated Show resolved Hide resolved
@mpoke mpoke requested a review from MSalopek January 30, 2024 18:39
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please appease linter before merge.

@sainoe sainoe self-requested a review February 1, 2024 10:14
Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mpoke mpoke merged commit 1e5cccc into main Feb 1, 2024
17 checks passed
@mpoke mpoke deleted the marius/2911-gov-spam branch February 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GovPreventSpamDecorator is no longer needed
3 participants