deps: update several things at once (sdk, ibc-go, btcd) #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
shaspitz
changed the title
shaspitz
requested review from
alexanderbez,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe and
MSalopek
as code owners
shaspitz
changed the title
|
This PR doesn't work on top of main without bumping comet, which we cannot do because of cometbft/cometbft#773, therefore I'll make this PR a draft, it will most likely be closed. |
|
The comet issue is not a problem after @MSalopek debugged, I've re-bumped comet to 0.24.28 |
jtremback
approved these changes
May 18, 2023
There was a problem hiding this comment.
LGTM, but before we deploy this, I'd really like @glnro @yaruwangway and @mmulji-ic to double check our removal of those replace statements
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
* bumps * ibc-go * ibc-go v4.4.0 * downgrade ICS back to v1.1.1 * Update CHANGELOG.md * downgrade comet to 0.34.27 * bump comet again * Update CHANGELOG.md --------- Co-authored-by: Jacob Gadikian <[email protected]> (cherry picked from commit 4991414) # Conflicts: # go.mod # go.sum
shaspitz
added a commit
that referenced
this pull request
May 18, 2023
…) (#2503) * deps: update several things at once (sdk, ibc-go, btcd) (#2498) * bumps * ibc-go * ibc-go v4.4.0 * downgrade ICS back to v1.1.1 * Update CHANGELOG.md * downgrade comet to 0.34.27 * bump comet again * Update CHANGELOG.md --------- Co-authored-by: Jacob Gadikian <[email protected]> (cherry picked from commit 4991414) # Conflicts: # go.mod # go.sum * fix conflicts --------- Co-authored-by: Shawn <[email protected]>
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @faddat, original PR here #2490. I just needed to add shaspitz@e2324f2 to make the work mergable
Description
This PR bumps to
And removes some replace statements
Comet stays at 0.34.27 because 0.34.28 seems to have an issue with halting under certain conditions, and 0.34.27 is used by IBC 4.4.0.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change