-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: move BypassMinFeeMsgTypes and MaxTotalBypassMinFeeMsgGasUsage to params #2424
Conversation
…g_gas_usage to globalfee params
"mixed valid and invalid msgs, fail": { | ||
[]string{ | ||
"/ibc.core.channel.v1.MsgRecvPacket", | ||
"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just use the invalid example from above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They aren't the same. A leading "/" is missing in the msg-type above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…nesis call collect-gentx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Add
BypassMinFeeMsgTypes
andMaxTotalBypassMinFeeMsgGasUsage
to the GlobalFee params.The AnteHandler is now accessing these values from the paramstore instead of the
app.toml
config file.This PR partially closes #2366 and doesn't contain the migration and the config refactoring work which will be addressed by
these two PRs: #2352 #2369.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change