Sync up with SDK's latest changes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## rigel/refactor-update #24 +/- ##
========================================================
Coverage ? 56.34%
========================================================
Files ? 4
Lines ? 197
Branches ? 0
========================================================
Hits ? 111
Misses ? 83
Partials ? 3 |
sabau
reviewed
May 28, 2019
| @@ -317,7 +317,7 @@ func InitializeTestLCD(t *testing.T, nValidators int, initAddrs []sdk.AccAddress | |||
| stakingDataBz = cdc.MustMarshalJSON(stakingData) | |||
| genesisState[staking.ModuleName] = stakingDataBz | |||
|
|
|||
| genaccountsData := genaccounts.NewGenesisState(accs) | |||
| genaccountsData := genaccounts.GenesisState(accs) | |||
There was a problem hiding this comment.
This name comes from the SDK so we can't do much here. But sounds like genaccounts.GenesisState is in fact returning a set of accounts, the name of the function is misleading.
sabau
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #22
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: