Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc v4 for v8 #2012

Closed
wants to merge 4 commits into from
Closed

ibc v4 for v8 #2012

wants to merge 4 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 12, 2023

I think it might make a lot of sense to jump to ibc v4 in v8.

This way, we're using "fresher" upstream code.

Note: this may require an ibc-go migration / upgrade handler, but I'm headed to bed now :)

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2012 (97b6383) into fix-v8 (d9de8ca) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           fix-v8    #2012   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files          23       23           
  Lines        1565     1565           
=======================================
  Hits         1237     1237           
  Misses        274      274           
  Partials       54       54           

@glnro
Copy link
Contributor

glnro commented Jan 12, 2023

Hey @faddat this would be great if v8 was happening in isolation, but the catch is it's going to be followed immediately by v9 with ICS which is still dependent on v3.4.0... tagging @mpoke @jtremback for input.

@faddat
Copy link
Contributor Author

faddat commented Jan 12, 2023

Ah so I think that @yaruwangway is working on a v9 with v4.2.0

My thinking is that this will get an upgrade out of the way in V8, so we can have fewer changes in v9

@faddat
Copy link
Contributor Author

faddat commented Jan 12, 2023

I'll also be having some pokes at ccv this week, and looking into consumer chains. I'd like to use 47 when prototyoing them... Will see what I see :).

Probably next week though.

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@glnro
Copy link
Contributor

glnro commented Jan 13, 2023

@faddat closing this just to consolidate as there is already a spike to look at 4.2 in V9 though the likely scenario is 4.2 in v10. V8 will launch with 3.4

@glnro glnro closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants