Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove ica controller params setup from upgrade handler #1989

Merged
merged 2 commits into from
Jan 6, 2023
Merged

fix: remove ica controller params setup from upgrade handler #1989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583edb7
fix: remove ica controller params setup from upgrade handler
Jan 6, 2023
2f76c6f
merge main
Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions app/upgrades/v8/upgrades.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"github.com/cosmos/cosmos-sdk/types/module"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
icacontrollertypes "github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/types"
icahosttypes "github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/types"
icatypes "github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/types"
ibcchanneltypes "github.com/cosmos/ibc-go/v3/modules/core/04-channel/types"
Expand Down Expand Up @@ -115,11 +114,6 @@ func CreateUpgradeHandler(
return vm, err
}

// Enable controller chain
controllerParams := icacontrollertypes.Params{
ControllerEnabled: true,
}

// Change hostParams allow_messages = [*] instead of whitelisting individual messages
hostParams := icahosttypes.Params{
HostEnabled: true,
Expand All @@ -128,7 +122,6 @@ func CreateUpgradeHandler(

// Update params for host & controller keepers
keepers.ICAHostKeeper.SetParams(ctx, hostParams)
keepers.ICAControllerKeeper.SetParams(ctx, controllerParams)

ctx.Logger().Info("upgrade complete")

Expand Down