This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
update chain-id format #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
changed the base branch from
development
to
fedekunze/msg-ethermint
Codecov Report
@@ Coverage Diff @@
## fedekunze/msg-ethermint #541 +/- ##
===========================================================
+ Coverage 70.60% 70.67% +0.07%
===========================================================
Files 43 43
Lines 2228 2237 +9
===========================================================
+ Hits 1573 1581 +8
Misses 516 516
- Partials 139 140 +1
Continue to review full report at Codecov.
|
fedekunze
commented
Sep 24, 2020
Comment on lines
+31
to
+33
| chainIDEpoch, err := ethermint.ParseChainID(ctx.ChainID()) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
@noot this is where we parse the chain ID epoch number for ethereum compatibility
noot
approved these changes
Sep 24, 2020
noot
suggested changes
Sep 24, 2020
There was a problem hiding this comment.
getting some errors when sending a tx:
$ geth attach http://172.17.0.2:8545
> eth.sendTransaction({from: eth.accounts[0], to: eth.accounts[0], value: 0x1})
Error: invalid chain ID: 17: failed to simulate tx
at web3.js:6347:37(47)
at web3.js:5081:62(37)
at <eval>:1:20(16)
|
@fedekunze figured out the issue, could you change this so we cannot use an invalid chain ID (ie |
noot
approved these changes
Sep 24, 2020
|
replaced by #542 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #540