This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking Tooling #399
Benchmarking Tooling #399
Changes from 36 commits
c8b38eb
e9708f2
fd7ba83
a87cb71
ee5cf56
9c17d46
da5db2f
32279f2
b551d3b
ad98544
0a98995
9bde2bf
668725a
35e7b52
e618df5
fc2b6cf
0a36c72
31cb53d
f9024f8
ef24a09
d7a4f61
62fb328
a2d693a
dbb442f
a287315
e175359
719f66e
c841ce1
df97e18
08ecf4e
029fc6d
73550b9
89a995e
1434136
159e133
58651c0
3fce491
3c9b285
9b7015e
b5090f4
3c70be0
db8730a
6a9a6dc
cc5c99b
b3c5aea
d4eed61
9964973
0427010
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit add godoc comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move out of the struct and pass it as a field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto godoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address lint issue