eth_getFilterLogs, eth_getLogs implementation #248
Conversation
* evm: move Begin and EndBlock to abci.go * evm: use expected keeper interfaces * app: use EthermintApp for integration and unit test setup * evm: remove count type; update codec * go mod verify * evm: rename msgs for consistency * evm: events * minor cleanup * lint * ante: update tests * changelog * nolint
There was a problem hiding this comment.
tested the changes and it seems that the contract can't be deployed (the transaction is processed but doesn't return anything to the web3 interface). Other than that the changes LGTM
yarn start
yarn run v1.15.2
$ node ./web3/deploy_contract.js
Compiling contract code...
Unlocked account address: 0x0D08F68360524d01c0be5e2c4128836b653BD469
Deploying contract...
``
| Simulate: ctx.IsCheckTx(), | ||
| } | ||
| // Prepare db for logs | ||
| k.CommitStateDB.Prepare(ethHash, common.Hash{}, k.TxCount) | ||
| // TODO: block hash |
There was a problem hiding this comment.
is this to add the block hash to the Prepare fields?
There was a problem hiding this comment.
yeah, right now it uses txHash for both fields
|
are you deploying the same contract in the script? will take a look |
yeah I'm using |
|
@fedekunze should be fixed now! however, the tx hash returned by eth_sendTransaction doesn't match the hash of the ethereum transaction message, do you know how the tx hash in eth_sendTransaction is being calculated? https://github.com/ChainSafe/ethermint/blob/af8133464b95db447090a7c6d618763672e510f2/rpc/eth_api.go#L294 edit: nvm I see what's happening, will update |
|
@fedekunze will add now! |
Closes: #54 closes #55
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer