store logs in keeper after transition #210

noot · 2020-03-11T17:02:22Z

Closes: #180

Description

update TransitionCSDB to return logs, and to store the logs in the sdk result
update EncodeReturnData -> EncodeResultData, DecodeReturnData -> DecodeResultData to use rlp encoding
update handleETHTxMsg to store logs in KVStore after transition occurs
add SetBlockLogs and GetBlockLogs to keeper

.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

x/evm/handler_test.go

x/evm/types/utils.go

x/evm/keeper/keeper.go

…t/exploration

x/evm/types/state_transition.go

x/evm/handler_test.go

x/evm/keeper/keeper.go

x/evm/types/state_transition.go

x/evm/abci.go

x/evm/keeper/keeper_test.go

fedekunze

LGTM, minor comments only before merging

x/evm/types/utils.go

x/evm/keeper/querier.go

x/evm/handler_test.go

x/evm/types/utils_test.go

fedekunze

LGTM. One comment only that I missed before. Can you fix the conflicts too 🙏?

x/evm/handler.go

noot · 2020-03-18T14:17:41Z

@fedekunze fixed!

fedekunze

utACK

@AustinBell

* evm: move Keeper and Querier to /keeper package * keeper: update keeper_test.go * fix format * evm: use aliased types * bump SDK version to v0.38.1 * app: updates from new version * errors: switch sdk.Error -> error * errors: switch sdk.Error -> error. Continuation * more fixes * update app/ * update keys and client pkgs * build * fix tests * lint * minor changes * changelog * address @AustinBell comments * Fix keyring usage in rpc API and CLI * fix keyring * break line * Misc cleanup (#188) * evm: move Begin and EndBlock to abci.go * evm: use expected keeper interfaces * app: use EthermintApp for integration and unit test setup * evm: remove count type; update codec * go mod verify * evm: rename msgs for consistency * evm: events * minor cleanup * lint * ante: update tests * changelog * nolint * evm: update statedb to create ethermint Account instead of BaseAccount * fix importer test * address @austinabell comments * update README * changelog * evm: update codec * fix event sender * store logs in keeper after transition (#210) * add some comments * begin log handler test * update TransitionCSDB to return ReturnData * use rlp for result data encode/decode * update tests * implement SetBlockLogs * implement GetBlockLogs * test log set/get * update keeper get/set logs to use hash as key * fix test * move logsKey to csdb * attempt to fix test * attempt to fix test * attempt to fix test * lint * lint * lint * save logs after handling msg * update k.Logs * cleanup * remove unused * fix issues * comment out handler test * address comments * lint * fix handler test * address comments * use amino * lint * address comments * merge * fix encoding bug * minor fix * rpc: error handling * rpc: simulate only returns gasConsumed * rpc: error ineffassign * go: bump version to 1.14 and SDK version to latest master * rpc: fix simulation return value * breaking changes from SDK * sdk: breaking changes; build * tests: fixes * minor fix * proto: ethermint types attempt * proto: define EthAccount proto type and extend sdk std.Codec * evm: fix panic on handler test * evm: minor state object changes * cleanup * tests: update test-importer * fix pubkey registration * lint * cleanup * more test checks for importer * minor change * codec fixes * rm init func * fix importer test build * fix marshaling for TxDecoder * use amino codec for evm * fix marshaling for SimulationResponse * use jsonpb for unmarshaling * fix method handler crashed * return err on VerifySig * switch stateObject balance to sdk.Int * fixes to codec and encoding * cleanup * set tmhash -> ethhash in state transition * add tmhash->ethereumhash to csdb.GetLogs * attempt to fix tests * update GetLogs to switch with Has * ante panic * diff changes * update SetLogs * evm/cli: use ethermint codec * use LengthPrefixed for encoding * add check for nil *big.Int * add balance to UpdateAccounts * fix previous balance * fix balance bug * prevent panic on make test-import Co-authored-by: austinabell <[email protected]> Co-authored-by: noot <[email protected]> Co-authored-by: noot <[email protected]>

@AustinBell

* evm: move Keeper and Querier to /keeper package * keeper: update keeper_test.go * fix format * evm: use aliased types * bump SDK version to v0.38.1 * app: updates from new version * errors: switch sdk.Error -> error * errors: switch sdk.Error -> error. Continuation * more fixes * update app/ * update keys and client pkgs * build * fix tests * lint * minor changes * changelog * address @AustinBell comments * Fix keyring usage in rpc API and CLI * fix keyring * break line * Misc cleanup (#188) * evm: move Begin and EndBlock to abci.go * evm: use expected keeper interfaces * app: use EthermintApp for integration and unit test setup * evm: remove count type; update codec * go mod verify * evm: rename msgs for consistency * evm: events * minor cleanup * lint * ante: update tests * changelog * nolint * evm: update statedb to create ethermint Account instead of BaseAccount * fix importer test * address @austinabell comments * update README * changelog * evm: update codec * rename GasLimit->Gas and Price ->GasPrice * msg cleanup and tests * cleanup TxData * fix marshaling * revert rename * move types * evm/keeper: querier tests * switch MarshalLengthPrefixed -> BinaryBare; remove panics * fix event sender * fix panic * try fix txDecoder error * evm: handler tests * evm: handler MsgEthermint test * fix tests * store logs in keeper after transition (#210) * add some comments * begin log handler test * update TransitionCSDB to return ReturnData * use rlp for result data encode/decode * update tests * implement SetBlockLogs * implement GetBlockLogs * test log set/get * update keeper get/set logs to use hash as key * fix test * move logsKey to csdb * attempt to fix test * attempt to fix test * attempt to fix test * lint * lint * lint * save logs after handling msg * update k.Logs * cleanup * remove unused * fix issues * comment out handler test * address comments * lint * fix handler test * address comments * use amino * lint * address comments * merge * fix encoding bug * minor fix * rpc: error handling * rpc: simulate only returns gasConsumed * rpc: error ineffassign * evm: handler test * go: bump version to 1.14 and SDK version to latest master * rpc: fix simulation return value * breaking changes from SDK * sdk: breaking changes; build * tests: fixes * minor fix * proto: ethermint types attempt * proto: define EthAccount proto type and extend sdk std.Codec * evm: fix panic on handler test * evm: minor state object changes * cleanup * tests: update test-importer * fix evm test * fix pubkey registration * lint * cleanup * more test checks for importer * minor change * codec fixes * rm init func * fix importer test build * fixes * test fixes * fix bloom key * rm unnecesary func * remove comment Co-authored-by: austinabell <[email protected]> Co-authored-by: noot <[email protected]>

noot added 6 commits March 4, 2020 18:11

add some comments

fe5cfe5

begin log handler test

d00e3c6

update TransitionCSDB to return ReturnData

496edc2

use rlp for result data encode/decode

57eaae2

update tests

beaccb4

merge with development

dec0d62

noot self-assigned this Mar 11, 2020

golangcibot reviewed Mar 11, 2020

View reviewed changes

x/evm/handler_test.go Outdated Show resolved Hide resolved

x/evm/types/utils.go Outdated Show resolved Hide resolved

noot added 2 commits March 13, 2020 11:19

implement SetBlockLogs

b4df9f9

implement GetBlockLogs

11d7add

golangcibot reviewed Mar 13, 2020

View reviewed changes

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved

noot added 4 commits March 13, 2020 13:48

test log set/get

5a6f4e1

Merge branch 'development' of github.com:ChainSafe/ethermint into noo…

ce5e4a4

…t/exploration

update keeper get/set logs to use hash as key

7b0d0bf

fix test

5869475

noot commented Mar 13, 2020

View reviewed changes

x/evm/types/state_transition.go Outdated Show resolved Hide resolved

noot added 3 commits March 13, 2020 15:01

move logsKey to csdb

d668e7b

attempt to fix test

1ed2483

attempt to fix test

a8fee1d

golangcibot reviewed Mar 13, 2020

View reviewed changes

x/evm/handler_test.go Outdated Show resolved Hide resolved

noot added 2 commits March 13, 2020 15:28

attempt to fix test

b5cf096

lint

9114d47

golangcibot reviewed Mar 13, 2020

View reviewed changes

x/evm/handler_test.go Outdated Show resolved Hide resolved

noot added 2 commits March 13, 2020 15:36

lint

6741a87

lint

d5fce93

golangcibot reviewed Mar 13, 2020

View reviewed changes

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved

save logs after handling msg

5bbf735

noot changed the title ~~store logs in KVStore after transition~~ store logs in keeper after transition Mar 13, 2020

update k.Logs

e66bf4c

noot marked this pull request as ready for review March 13, 2020 19:57

noot added 2 commits March 16, 2020 18:58

fix issues

bcbd905

merge wtih development

bd493e7

fedekunze reviewed Mar 16, 2020

View reviewed changes

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved

noot added 3 commits March 16, 2020 21:05

merge with version bump

0202547

comment out handler test

e285fd0

merge with development

e11b238

golangcibot reviewed Mar 17, 2020

View reviewed changes

x/evm/types/state_transition.go Show resolved Hide resolved

x/evm/types/state_transition.go Show resolved Hide resolved

x/evm/abci.go Outdated Show resolved Hide resolved

x/evm/keeper/keeper_test.go Outdated Show resolved Hide resolved

noot added 3 commits March 17, 2020 10:29

address comments

045e41a

lint

7f47916

fix handler test

a22277e

noot requested review from fedekunze and austinabell March 17, 2020 15:18

fedekunze changed the base branch from development to fedekunze/177-bump-sdk-version March 17, 2020 18:52

fedekunze suggested changes Mar 17, 2020

View reviewed changes

noot added 2 commits March 17, 2020 18:35

address comments

6a9e1bf

use amino

5e615f4

golangcibot reviewed Mar 17, 2020

View reviewed changes

x/evm/types/utils_test.go Outdated Show resolved Hide resolved

lint

22e16bf

noot requested a review from fedekunze March 18, 2020 00:24

fedekunze reviewed Mar 18, 2020

View reviewed changes

x/evm/handler.go Outdated Show resolved Hide resolved

x/evm/handler.go Outdated Show resolved Hide resolved

noot added 3 commits March 18, 2020 10:16

address comments

a9ecb7f

merge

977f06f

merge

4a8e64a

noot requested a review from fedekunze March 18, 2020 15:05

fedekunze approved these changes Mar 18, 2020

View reviewed changes

fedekunze merged commit d0aa494 into fedekunze/177-bump-sdk-version Mar 18, 2020

fedekunze deleted the noot/exploration branch March 18, 2020 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

store logs in keeper after transition #210

store logs in keeper after transition #210

noot commented Mar 11, 2020 •

edited

Loading

fedekunze left a comment

fedekunze left a comment

noot commented Mar 18, 2020

fedekunze left a comment

store logs in keeper after transition #210

store logs in keeper after transition #210

Conversation

noot commented Mar 11, 2020 • edited Loading

Description

.

fedekunze left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

noot commented Mar 18, 2020

fedekunze left a comment

Choose a reason for hiding this comment

noot commented Mar 11, 2020 •

edited

Loading