This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
run linter in CI #311
Merged
run linter in CI #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #311 +/- ##
==========================================
Coverage ? 24.91%
==========================================
Files ? 11
Lines ? 578
Branches ? 0
==========================================
Hits ? 144
Misses ? 410
Partials ? 24Continue to review full report at Codecov.
|
odeke-em
approved these changes
Sep 23, 2017
cmd/utils/parse_test.go
Outdated
| g := new(core.Genesis) | ||
| if err := json.Unmarshal(defaultGenesisBlob, g); err != nil { | ||
| log.Fatalf("parsing defaultGenesis: %v", err) | ||
| } | ||
| return g | ||
| }() | ||
|
|
||
| func bigString(s string) *big.Int { | ||
| func bigString() *big.Int { |
There was a problem hiding this comment.
I am not sure we should change this, as it is there for convenience despite not using another string except "10000000000000000000000000000000000"
There was a problem hiding this comment.
i just go by the linting suggestions. if you think it's better to // nolint then we can
There was a problem hiding this comment.
Let's keep it how it is and add // nolint.
adrianbrink
previously requested changes
Sep 25, 2017
cmd/utils/parse_test.go
Outdated
| g := new(core.Genesis) | ||
| if err := json.Unmarshal(defaultGenesisBlob, g); err != nil { | ||
| log.Fatalf("parsing defaultGenesis: %v", err) | ||
| } | ||
| return g | ||
| }() | ||
|
|
||
| func bigString(s string) *big.Int { | ||
| func bigString() *big.Int { |
There was a problem hiding this comment.
Let's keep it how it is and add // nolint.
zramsay
force-pushed
the
fix-linting
branch
2 times, most recently
from
b424c14
to
8a21433
Compare
|
done |
zramsay
force-pushed
the
fix-linting
branch
from
8a21433
to
d1f02e2
Compare
|
@zramsay The problem remains, that circle ci does not have enough memory to run the entire linter. Either we have to turn some of these off for now or we really need to upgrade circle. |
|
weird. I've had no problems running linter in other repos ... |
|
Ethermint is a really large codebase with its dependencies. It might be something else. @zramsay Can you investigate this and see if you can get CircleCi to pass because I think this PR is super helpful for code quality. |
adrianbrink
force-pushed
the
fix-linting
branch
from
a0214be
to
92fcd85
Compare
adrianbrink
force-pushed
the
fix-linting
branch
from
1e512f6
to
61d23fb
Compare
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linter: run it during CI * Break import cycle in ethereum package * Disable all linters and enable only unused
i-norden
pushed a commit
to vulcanize/old_ethermint
that referenced
this pull request
Aug 31, 2020
* vuepress * docs: vuepress setup and TODOs * doc scripts * update Makefile and gitignore * more docs updates * gitignore * metamask instructions * update image * updates * updates from call * docs: vuepress config and home.vue (cosmos#350) * update uncles return (cosmos#337) * x/evm: fix EndBlock consensus failure (cosmos#334) * add test for sending tx w/ 21000 gas * improve rpc transfer test * use ctx in EndBlock * UpdateAccounts and ClearStateObjects with passed in context * log ethereum address on error Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Federico Kunze <[email protected]> * update Ethermint color variables * add header and footer logo * tweak config.js * WIP custom homepage.vue * add layout to docs/README * update color variables * add eth logo black and white * tweak docs/README * update logo and logo-bw svg * bump 1.0.167 * homepage → home * add icon-code, icon-rocket * layout: home, remove configurable frontmatter: label, read, use * clean up config.js * bump 1.0.168 * fix missing comma from resolving conflicts * update sidebar, config nav, path * remove left whitespace on the header and footer logos * clean up home.vue, docs/README * update ethermint forum url in footer.links * comment out custom true to enable searchbar in subpages * remove external link icon for Guides * comments, revert custom true * clean up config.js, add specifications icon Co-authored-by: noot <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Federico Kunze <[email protected]> * final touches Co-authored-by: Cyrus Goh <[email protected]> Co-authored-by: noot <[email protected]>
faddat
pushed a commit
to faddat/ethermint
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and address a few fixes