Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmovisor test download url #9926

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

ryanchristo
Copy link
Contributor

Description

Closes: #9919

This pull request updates the location of the download binary used in cosmovisor tests.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Aug 12, 2021
@ryanchristo ryanchristo marked this pull request as ready for review August 12, 2021 17:31
@alexanderbez alexanderbez merged commit 1224bd4 into master Aug 12, 2021
@alexanderbez alexanderbez deleted the ryan/9919-fix-cosmovisor-test branch August 12, 2021 19:05
@orijbot
Copy link

orijbot commented Aug 12, 2021

@alexanderbez
Copy link
Contributor

alexanderbez commented Aug 12, 2021

@ryanchristo looks like we missed one? https://github.com/cosmos/cosmos-sdk/pull/9921/checks?check_run_id=3315225438 (this ran after this PR was merged I believe).

@ryanchristo
Copy link
Contributor Author

@ryanchristo looks like we missed one? https://github.com/cosmos/cosmos-sdk/pull/9921/checks?check_run_id=3315225438 (this ran after this PR was merged I believe).

Oof. Not immediately visible where that one is coming from. Looking into it.

@ryanchristo
Copy link
Contributor Author

It's in one of the zip files. Will open another pull request to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cosmovisor tests on master
3 participants