fix!: update ABCI query to use request height #9879

colin-axner · 2021-08-09T10:07:35Z

Description

Closes: #9433

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

fix ABCI Query to use request height instead of context height Add tests to test query height change

orijbot · 2021-08-09T10:07:39Z

Visit https://dashboard.github.orijtech.com?pr=9879&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details.

client/query_test.go

alexanderbez

🎉

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

tac0turtle

LGTM

amaury1093 · 2021-08-10T14:01:47Z

client/query.go

@@ -77,7 +77,7 @@ func (ctx Context) queryABCI(req abci.RequestQuery) (abci.ResponseQuery, error)
 	}

 	opts := rpcclient.ABCIQueryOptions{
-		Height: ctx.Height,
+		Height: req.Height,


In CLI (with --height) and grpc queries (with the height header), iirc we populate the client ctx.Height. So I think we should use req.Height if that's set, or fallback to ctx.Height.

I believe that's the cause of all failing tests

That makes sense. Is there a reason we don't populate the req in CLI and API pathways, instead of ctx? Just curious.

Is there a reason we don't populate the req in CLI and API pathways

Yeah that could work too, where do you see this logic happening?

So Context#queryABCI gets call from 2-3 places, one of which doesn't have a height to provide, so we cannot solely rely on req.Height.

I would do two things:

Update RunGRPCQuery to set Height in abciReq.

Update your logic to fallback on ctx.Height if req.Height is zero.

Set request height in abciReq for RunGRPCQuery Only use the request height in the ABCI Query if it is set, otherwise fallback to context height

…sdk into colin/9433-abci-query-fix

Use table test format and adding more test cases

amaury1093

LGTM!

codecov · 2021-08-11T16:05:38Z

Codecov Report

Merging #9879 (55fa25a) into master (e656d5e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9879      +/-   ##
==========================================
+ Coverage   63.60%   63.61%   +0.01%     
==========================================
  Files         568      568              
  Lines       53511    53519       +8     
==========================================
+ Hits        34037    34048      +11     
+ Misses      17549    17546       -3     
  Partials     1925     1925

Impacted Files	Coverage Δ
client/grpc_query.go	`36.98% <100.00%> (+0.87%)`	⬆️
client/query.go	`31.32% <100.00%> (+11.58%)`	⬆️
crypto/keys/internal/ecdsa/privkey.go	`82.45% <0.00%> (-1.76%)`	⬇️

alexanderbez · 2021-08-12T14:42:10Z

Are the cosmovisor tests expected to fail? Are they broken or are they related to this PR?

amaury1093 · 2021-08-12T14:44:05Z

No they're broken on master too, see #9919. @alexanderbez if you have admin rights, feel free to merge this PR, and let's work on fixing cosmovisor tests in another PR

colin-axner · 2021-09-14T15:49:31Z

Adding backport label. This would be useful for the go relayer and we can discuss whether it should be backported on the backport pr

An alternative solution is to modify the ibc code in the stargate version to account for this issue

(cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md

alexanderbez · 2021-09-14T21:07:57Z

This backport is OK as agreed upon in the SDK planning call.

robert-zaremba · 2021-09-16T21:41:35Z

This should go into 0.44 as well

robert-zaremba · 2021-09-16T21:41:40Z

@Mergifyio backport release/v0.44.x

(cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md

mergify · 2021-09-16T21:42:24Z

Command backport release/v0.44.x: success

Backports have been created

#10185 fix!: update ABCI query to use request height (backport #9879) has been created for branch release/v0.44.x

* fix!: update ABCI query to use request height (#9879) (cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: colin axnér <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>

…osmos#10144)

…osmos#10185) * fix!: update ABCI query to use request height (cosmos#9879) (cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: colin axnér <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>

* [capricorn] cosmos-sdk v0.42.9 to v0.42.10 (cosmos#117) * fix: file keyring fails to add/import/export keys when input is not stdin (fix cosmos#9566) (backport cosmos#9821) (cosmos#9880) * fix: file keyring fails to add/import/export keys when input is not stdin (fix cosmos#9566) (cosmos#9821) ## Description Add a test case to reproduce the issue described in cosmos#9566. The test currently fails, and I've pointed some possible solutions over cosmos#9566 (comment). But I feel this needs more works in order to provide a more robust solution. I'll keep poking at better options, but taking any pointers if anyone has ideas. (cherry picked from commit f479b51) # Conflicts: # client/keys/add.go # client/keys/add_test.go # client/keys/export_test.go * fix: merge conflict backporting pr-9821 (cosmos#9888) Co-authored-by: daeMOn <[email protected]> * fix: Fix CLI query tx docs for acc/seq (cosmos#9942) (cosmos#9951)  ## Description ref: user from #validators-verfied channel on Cosmos Discord  * build(deps): bump TM to v0.34.12 (backport cosmos#9956) (cosmos#9961) * perf: Remove telemetry from wrappings of store (backport cosmos#10077) (cosmos#10084) * docs: update to v0.44 version tag (cosmos#10069) (cosmos#10097) (cherry picked from commit d6c3017) # Conflicts: # docs/.vuepress/enhanceApp.js Co-authored-by: Ryan Christoffersen <[email protected]> * fix!: update ABCI query to use request height (backport cosmos#9879) (cosmos#10144) * fix: use keyring in config for add-genesis-account cmd (backport cosmos#9969) (cosmos#10065) * fix: use keyring in config for add-genesis-account cmd (cosmos#9969)  ## Description ref: cosmos#9644 +use the keyring backend (if specified) in the binary config for the add-genesis-account command +update existing test to check for the case of keyring in config * build(deps): bump github.com/tendermint/tendermint from 0.34.12 to 0.34.13 (backport cosmos#10106) (cosmos#10107) * build(deps): bump github.com/tendermint/tendermint (cosmos#10106) (cherry picked from commit 8ee5e50) * fix go.sum Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Robert Zaremba <[email protected]> * perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (backport cosmos#10026) (cosmos#10114) * perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (cosmos#10026) (cherry picked from commit 28bf2c1) # Conflicts: # CHANGELOG.md # store/cachekv/store.go * Fix merge conflict * fix changelog Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: ValarDragon <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> * chore: bump IAVL version (backport cosmos#10040) (cosmos#10186) * chore: bump IAVL version (cosmos#10040) * chore: bump IAVL version * test master * update IAVL version * adding missing go.sum entry * adding missing entries * fix go.sum * clear go.sum * fixing go.sum Co-authored-by: marbar3778 <[email protected]> (cherry picked from commit 693ffb1) * add changelog update * tidy go.mod Co-authored-by: Robert Zaremba <[email protected]> * feat: backport reject redundant transactions from ibc-go (cosmos#10211) * backport refund of redundant packets from ibc-go * update changelog * address review comments and lint errors * added nolint Co-authored-by: Carlos Rodriguez <[email protected]> * chore: Changelog and Release Notes for 0.42.10 (cosmos#10242) * chores: bump tendermint version * fix: add required helper for group module Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: ValarDragon <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Amaury <[email protected]> * fix: add hack to handle group v2 messages in baseapp (cosmos#118) * fix: add hack to handle group v2 messages in baseapp * chores: disable lint warning * feat: backport caelum bls on v0.42 sdk (cosmos#119) * Bls (cosmos#104) * bls signature for basic account * benchmark for bls and ed25519 * added bls sig verify cost to genesis * Revert "Merge branch 'fetchai:master' into bls" This reverts commit a5dd8ea9c1597c285e9375f168dd7af51e76f6b3, reversing changes made to 082e0710e3dd2f96733e76f8e2f928c2d7e4ab29. * format using go tools * nuisance golangci-lint errors * Bls (cosmos#105) * bls signature for basic account * benchmark for bls and ed25519 * added bls sig verify cost to genesis * Revert "Merge branch 'fetchai:master' into bls" This reverts commit a5dd8ea9c1597c285e9375f168dd7af51e76f6b3, reversing changes made to 082e0710e3dd2f96733e76f8e2f928c2d7e4ab29. * format using go tools * nuisance golangci-lint errors * POP interfaces in accounts and authentication * add bls multsig operations * fixed golangci-lint error * changes after comments * change codespace for invalid pop error * extend migrate with bls cost * set bls cost multiplier * fix ante test errors * feat: Caelum (cosmos#111) * bls signature for basic account * benchmark for bls and ed25519 * added bls sig verify cost to genesis * Revert "Merge branch 'fetchai:master' into bls" This reverts commit a5dd8ea9c1597c285e9375f168dd7af51e76f6b3, reversing changes made to 082e0710e3dd2f96733e76f8e2f928c2d7e4ab29. * format using go tools * nuisance golangci-lint errors * Bls (cosmos#104) * bls signature for basic account * benchmark for bls and ed25519 * added bls sig verify cost to genesis * Revert "Merge branch 'fetchai:master' into bls" This reverts commit a5dd8ea9c1597c285e9375f168dd7af51e76f6b3, reversing changes made to 082e0710e3dd2f96733e76f8e2f928c2d7e4ab29. * format using go tools * nuisance golangci-lint errors * POP interfaces in accounts and authentication * add bls multsig operations * fixed golangci-lint error * changes after comments * initial commit from regen-ledger/x/group v1.0.0 * minor changes to bls12381 key generation * initial commit from regen-ledger/proto/regen/group v1.0.0 * group module compatibility for fetchai cosomos-sdk * add bls account restriction to group members * fix bug in setting pop * make msg uniqueness checking optional * add bls basic/aggregate vote * add checking on empty messages/public keys * add gas caclulation/consumption for verifying aggregated votes * minor change to gas calculation for voteagg * initial commit for orm and types from regen-ledger v2.0.0-beta1 * upgrade testsuite to regen-ledger v2.0.0-beta1 * make bls requirement for group members optional * add tests for bls related group operations * client and server for poll and aggregated votes and integration tests * fix bls related test errors * fix proto-lint errors * goimport format * proto comments * update blst to v0.3.5 and more tests for bls * Update x/auth/ante/sigverify.go Co-authored-by: daeMOn <[email protected]> * Update x/group/client/util.go Co-authored-by: daeMOn <[email protected]> Co-authored-by: daeMOn <[email protected]> * fix: bls12381 compat with sdk v0.42 * fix: buf lint / breaking command changes * fix: staking test want more gas * chores: drop arm from CI test matrix * chores: fix lint Co-authored-by: kitounliu <[email protected]> Co-authored-by: kitty <[email protected]> * fix: more gas for simulations. Disable test caching Co-authored-by: kitounliu <[email protected]> Co-authored-by: kitty <[email protected]> * chores: revert bls integration (cosmos#121) * chores: bump sdk v0.42.11 (cosmos#123) * chores: revert bls integration * fix: --home flag parsing (backport cosmos#10226) (cosmos#10272) * fix: --home flag parsing (cosmos#10226)  ## Description Closes: #XXXX  * fix: null guard for tx fee amounts (backport cosmos#10327) (cosmos#10343) * fix: null guard for tx fee amounts (cosmos#10327) ## Description It is possible to submit a TX with a fees object containing a Coin with a nil amount. This results in a rather cryptic redacted panic response when the basic validation checks fee Coins for negative amounts. This PR adds an additional check for nil to provide a friendlier error message. * perf: Only do memory allocation when zero coin is found (backport cosmos#10339) (cosmos#10362) * perf: Only do memory allocation when zero coin is found (cosmos#10339) ## Description Closes: cosmos#10333 Added a loop that checks for zero coins before making any memory allocations. If no zero coins are found, just return the `coins` slice as is. If a zero coin is found, then allocate the new array, stop looking for the first zero, and restart the loop to "remove" the 0's. * build(deps): bump github.com/tendermint/tendermint from 0.34.13 to 0.34.14 (backport cosmos#10357) (cosmos#10376) * build(deps): bump github.com/tendermint/tendermint from 0.34.13 to 0.34.14 (cosmos#10357) Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.13 to 0.34.14. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tendermint/tendermint/releases">github.com/tendermint/tendermint's releases</a>.</em></p> <blockquote> <h2>0.34.14 (WARNING: BETA SOFTWARE)</h2> <p><a href="https://github.com/tendermint/tendermint/blob/v0.34.14/CHANGELOG.md#v0.34.14">https://github.com/tendermint/tendermint/blob/v0.34.14/CHANGELOG.md#v0.34.14</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md">github.com/tendermint/tendermint's changelog</a>.</em></p> <blockquote> <h2>v0.34.14</h2> <p>This release backports the <code>rollback</code> feature to allow recovery in the event of an incorrect app hash.</p> <h3>FEATURES</h3> <ul> <li><a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/6982">#6982</a> The tendermint binary now has built-in suppport for running the end-to-end test application (with state sync support) (<a href="https://github.com/cmwaters"><code>@cmwaters</code></a>).</li> <li>[cli] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/7033">#7033</a> Add a <code>rollback</code> command to rollback to the previous tendermint state. This may be useful in the event of non-determinstic app hash or when reverting an upgrade. <a href="https://github.com/cmwaters"><code>@cmwaters</code></a></li> </ul> <h3>IMPROVEMENTS</h3> <ul> <li><a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/7104">#7103</a> Remove IAVL dependency (backport of <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/6550">#6550</a>) (<a href="https://github.com/cmwaters"><code>@cmwaters</code></a>)</li> </ul> <h3>BUG FIXES</h3> <ul> <li><a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/7057">#7057</a> Import Postgres driver support for the psql indexer (<a href="https://github.com/creachadair"><code>@creachadair</code></a>).</li> <li>[ABCI] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7110">#7110</a> Revert "change client to use multi-reader mutexes (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/6873">#6873</a>)" (<a href="https://github.com/tychoish"><code>@tychoish</code></a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tendermint/tendermint/commit/85870def7b628effad73af942e638bbddf2ba8fd"><code>85870de</code></a> release: prepare changelog for 0.34.14 (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7105">#7105</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/ff2758b32e637b50734ad5ff1d0b24403af0deb2"><code>ff2758b</code></a> dep: remove IAVL dependency (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/6550">#6550</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7104">#7104</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/a82cb7dcda832b8c6475481bf404257a56aa2d18"><code>a82cb7d</code></a> Revert "abci: change client to use multi-reader mutexes (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/6306">#6306</a>)" (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7">#7</a>...</li> <li><a href="https://github.com/tendermint/tendermint/commit/1dfb3451eaaa438067dadb6835e9aa948689f39e"><code>1dfb345</code></a> e2e: light nodes should use builtin abci app (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7095">#7095</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7096">#7096</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/9f13b9b083da0ec45a48e57d5a283afdf698ba5b"><code>9f13b9b</code></a> e2e: abci protocol should be consistent across networks (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7078">#7078</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7085">#7085</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/16ba782fa6549ea1e50a7fe7addb538ff15bf619"><code>16ba782</code></a> cli: allow node operator to rollback last state (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7033">#7033</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7080">#7080</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/474ed04273bade74df583c7bfdc63e6e1a70a919"><code>474ed04</code></a> Import Postgres driver support for the psql indexer (backport). (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7057">#7057</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/2d8287d0f70962cc1d7bda0250def18962abf282"><code>2d8287d</code></a> e2e: allow running of single node using the e2e app (backport) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/7024">#7024</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/294a9695b4a768b4c8a9cb71c3562cdbff58e64c"><code>294a969</code></a> e2e: backport minor reliability improvements (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/6967">#6967</a>)</li> <li>See full diff in <a href="https://github.com/tendermint/tendermint/compare/v0.34.13...v0.34.14">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/tendermint/tendermint&package-manager=go_modules&previous-version=0.34.13&new-version=0.34.14)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) * fix: unmarshalling issue with multisig keys in master (backport cosmos#10061) (cosmos#10113) * fix: unmarshalling issue with multisig keys in master (cosmos#10061) (cherry picked from commit 3d3bc7c) # Conflicts: # CHANGELOG.md # crypto/keys/multisig/multisig_test.go * fix conflicts * fix conflicts * Update crypto/keys/multisig/multisig_test.go * Removed unused imports * fix changelog * Update CHANGELOG.md * Fix TestLegacyMultisig test (cosmos#10275) Co-authored-by: Henrik Aasted Sørensen <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Mario Karagiorgas <[email protected]> * fix: query account balance by ibc denom (backport cosmos#10394) (cosmos#10524) * fix: query account balance by ibc denom (cosmos#10394)  ## Description Closes: cosmos#10381  * chore: Iavl iterator (backport cosmos#10544) (cosmos#10546) * chore: Iavl iterator (cosmos#10544)  ## Description Closes: cosmos#10335 This PR adds a custom version of cosmos/iavl(cosmos/iavl#440) that removes the usage of channel-based approach on iterating IAVL tree. replaces cosmos#10404 * build(deps): Bump github.com/cosmos/iavl from 0.17.2 to 0.17.3 (backport cosmos#10654) (cosmos#10664) * build(deps): Bump github.com/cosmos/iavl from 0.17.2 to 0.17.3 (cosmos#10654) Bumps [github.com/cosmos/iavl](https://github.com/cosmos/iavl) from 0.17.2 to 0.17.3. - [Release notes](https://github.com/cosmos/iavl/releases) - [Changelog](https://github.com/cosmos/iavl/blob/v0.17.3/CHANGELOG.md) - [Commits](cosmos/iavl@v0.17.2...v0.17.3) * fix: Add Events to TxResponse (backport cosmos#10630) (cosmos#10644) * fix: Add Events to TxResponse (cosmos#10630) (cherry picked from commit c4bedf8) # Conflicts: # CHANGELOG.md # go.sum # types/abci.pb.go # types/result.go * Michael sucks * Who Let the Bugs Out?? * Reinventing the wheel. Again. * No changes made Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix: bech32 address test to satisfy the specification (cosmos#10163) (cosmos#10164) (cosmos#10665) ## Description Closes: cosmos#10163  * build(deps): Use self-maintained btcutil (cosmos#10082) (backport cosmos#10201) (cosmos#10622) * build(deps): Use self-maintained btcutil (cosmos#10082) (cosmos#10201) ## Description Closes: cosmos#10082 * chore: v0.42.11 changelog and release notes (cosmos#10695) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Henrik Aasted Sørensen <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Mario Karagiorgas <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * chores: go mod tidy Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: ValarDragon <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: kitounliu <[email protected]> Co-authored-by: kitty <[email protected]> Co-authored-by: Henrik Aasted Sørensen <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Mario Karagiorgas <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>

…osmos#10185) * fix!: update ABCI query to use request height (cosmos#9879) (cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: colin axnér <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>

fix, update ABCI query to use request height

2e4932d

fix ABCI Query to use request height instead of context height Add tests to test query height change

github-actions bot added the C:CLI label Aug 9, 2021

add changelog

15c2270

colin-axner changed the title ~~fix: update ABCI query to use request height~~ fix!: update ABCI query to use request height Aug 9, 2021

colin-axner marked this pull request as ready for review August 9, 2021 10:10

colin-axner requested review from aaronc and alexanderbez as code owners August 9, 2021 10:10

alexanderbez reviewed Aug 9, 2021

View reviewed changes

client/query_test.go Outdated Show resolved Hide resolved

alexanderbez approved these changes Aug 9, 2021

View reviewed changes

alexanderbez and others added 2 commits August 9, 2021 09:45

Merge branch 'master' into colin/9433-abci-query-fix

cf002dc

Update client/query_test.go

a385b75

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

tac0turtle approved these changes Aug 9, 2021

View reviewed changes

colin-axner added 2 commits August 9, 2021 17:09

fix tests

e4f28fd

Merge branch 'master' into colin/9433-abci-query-fix

f376a83

amaury1093 reviewed Aug 10, 2021

View reviewed changes

colin-axner added 5 commits August 11, 2021 17:35

apply review suggestions from Bez

860572c

Set request height in abciReq for RunGRPCQuery Only use the request height in the ABCI Query if it is set, otherwise fallback to context height

Merge branch 'colin/9433-abci-query-fix' of github.com:cosmos/cosmos-…

e534ec3

…sdk into colin/9433-abci-query-fix

update tests

ac4edc5

Use table test format and adding more test cases

update changelog and fix merge conflicts

aa76452

remove unnecessary changelog entry

2139665

alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 11, 2021

amaury1093 approved these changes Aug 11, 2021

View reviewed changes

Merge branch 'master' into colin/9433-abci-query-fix

55fa25a

alexanderbez merged commit c04ab50 into master Aug 12, 2021

alexanderbez deleted the colin/9433-abci-query-fix branch August 12, 2021 14:48

colin-axner added the backport/0.42.x (Stargate) label Sep 14, 2021

mergify bot pushed a commit that referenced this pull request Sep 14, 2021

fix!: update ABCI query to use request height (#9879)

7f71434

(cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md

mergify bot mentioned this pull request Sep 14, 2021

fix!: update ABCI query to use request height (backport #9879) #10144

Merged

robert-zaremba added the backport/0.44.x label Sep 14, 2021

alexanderbez pushed a commit that referenced this pull request Sep 15, 2021

fix!: update ABCI query to use request height (backport #9879) (#10144)

16e6b08

mergify bot pushed a commit that referenced this pull request Sep 16, 2021

fix!: update ABCI query to use request height (#9879)

ad7bfcc

(cherry picked from commit c04ab50) # Conflicts: # CHANGELOG.md

mergify bot mentioned this pull request Sep 16, 2021

fix!: update ABCI query to use request height (backport #9879) #10185

Merged

ValarDragon pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Sep 19, 2021

fix!: update ABCI query to use request height (backport cosmos#9879) (c…

c83d476

…osmos#10144)

fedekunze mentioned this pull request Nov 14, 2021

all: cherry pick olympus mons tharsis/cosmos-sdk#1

Closed

19 tasks

LeCodeurDuDimanche mentioned this pull request Nov 24, 2021

Handle yield calculation query with different query heights iov-one/starnamed#147

Closed

bluele mentioned this pull request Nov 16, 2022

Release v0.3: update ibc-go to v4.0.0 hyperledger-labs/yui-relayer#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix!: update ABCI query to use request height #9879

fix!: update ABCI query to use request height #9879

colin-axner commented Aug 9, 2021 •

edited

Loading

orijbot commented Aug 9, 2021

alexanderbez left a comment

tac0turtle left a comment

amaury1093 Aug 10, 2021

alexanderbez Aug 10, 2021

amaury1093 Aug 11, 2021

alexanderbez Aug 11, 2021

amaury1093 Aug 11, 2021

amaury1093 left a comment

codecov bot commented Aug 11, 2021 •

edited

Loading

alexanderbez commented Aug 12, 2021

amaury1093 commented Aug 12, 2021

colin-axner commented Sep 14, 2021

alexanderbez commented Sep 14, 2021

robert-zaremba commented Sep 16, 2021

robert-zaremba commented Sep 16, 2021

mergify bot commented Sep 16, 2021

fix!: update ABCI query to use request height #9879

fix!: update ABCI query to use request height #9879

Conversation

colin-axner commented Aug 9, 2021 • edited Loading

Description

Author Checklist

Reviewers Checklist

orijbot commented Aug 9, 2021

alexanderbez left a comment

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

amaury1093 Aug 10, 2021

Choose a reason for hiding this comment

alexanderbez Aug 10, 2021

Choose a reason for hiding this comment

amaury1093 Aug 11, 2021

Choose a reason for hiding this comment

alexanderbez Aug 11, 2021

Choose a reason for hiding this comment

amaury1093 Aug 11, 2021

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 11, 2021 • edited Loading

Codecov Report

alexanderbez commented Aug 12, 2021

amaury1093 commented Aug 12, 2021

colin-axner commented Sep 14, 2021

alexanderbez commented Sep 14, 2021

robert-zaremba commented Sep 16, 2021

robert-zaremba commented Sep 16, 2021

mergify bot commented Sep 16, 2021

colin-axner commented Aug 9, 2021 •

edited

Loading

codecov bot commented Aug 11, 2021 •

edited

Loading