-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --generate-only
and --offline
flags can use keyname.
#9838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9838 +/- ##
==========================================
+ Coverage 63.45% 63.55% +0.10%
==========================================
Files 568 568
Lines 53260 53372 +112
==========================================
+ Hits 33795 33922 +127
+ Misses 17543 17526 -17
- Partials 1922 1924 +2
|
…n-only-can-use-name
…n-only-can-use-name
Visit https://dashboard.github.orijtech.com?pr=9838&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
--generate-only
and --offline
flags can use keyname.--generate-only
and --offline
flags can use keyname.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, can you add a changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Closes: #9837
ref: #9407
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change